Java – SQLite database queries return only one row

SQLite database queries return only one row… here is a solution to the problem.

SQLite database queries return only one row

Below is the code I use to get all the results stored in the SQLite table. The problem I’m having is that when I know there are 21 rows in the database, it only returns one row.

public HashMap<String, String> fetchResults(String TABLE_NAME, String sql) {
    HashMap<String, String> table = new HashMap<String, String>();
    if(sql == null)
        sql = "";
    String selectQuery = "SELECT * FROM " + TABLE_NAME + " " + sql;

SQLiteDatabase db = this.getReadableDatabase();
    Cursor cursor = db.rawQuery(selectQuery, null);

String[] columns = null;
    switch(TABLE_NAME ){
    case "projects":
        columns = dbTables.projectsColumns;
        break;
    }

 Move to first row
    cursor.moveToFirst();
    if (cursor.getCount() > 0) {

int n=1;
        for(int i=0; i<columns.length; i++){
            table.put(columns[i], cursor.getString(n));
            n++;
        }

}
    move to the next row 
    cursor.moveToNext();

cursor.close();
    db.close();
     return user
    Log.d(TAG, "Fetching " + TABLE_NAME + " from Sqlite: " + table.toString());

return table;
}

The database call is made in a fragment and looks like this.

HashMap<String, String> projects = db.fetchResults(dbTables.TABLE_PROJECTS, null);

for (String key : projects.keySet()) {

if(key == "projectname"){
            System.out.println("Key: " + key + ", Value: " + projects.get(key));
            menuList.add(projects.get(key));
        }
    }

Solution

You retrieve only one row there:

// Move to first row
cursor.moveToFirst();
if (cursor.getCount() > 0) {
    int n=1;
    for(int i=0; i<columns.length; i++){
        table.put(columns[i], cursor.getString(n));
        n++;
    }
}

You must iterate over the cursor to get all the results:

// Move to first row
cursor.moveToFirst();
if (cursor.getCount() > 0) {
    while(cursor.moveToNext()) {
        for (int i = 0; i < columns.length; i++) {
            table.put(columns[i], cursor.getString(i));
        }
    }
}

However, your table lists all the column values for each row. If you want a table that contains row entries, define a class for storing column values.

Related Problems and Solutions