Java – “setView must have been called” – Custom class extension button

“setView must have been called” – Custom class extension button… here is a solution to the problem.

“setView must have been called” – Custom class extension button

So I have a 12 x 9 “button” grid called a “figure block”.
Tile.java extends the widget “button”.

I’m running into an issue now, though, I’m trying to get the button to display a toast that remembers the ID of the button pressed.

The grid is added dynamically and I want it to stay that way.

This is the code from GameBoardActivity.java:

This generates a 12×9 “square block” grid and adds a listener for each party block.

    public void gridRowButtons(int iterations){
    final Tile[] gridSpaces = new Tile[12];
    LinearLayout.LayoutParams buttonParams = new LinearLayout.LayoutParams(LayoutParams.MATCH_PARENT, LayoutParams.MATCH_PARENT, 1.0f);
    for (int i = 0; i < 12; i++) {
        String idString = String.valueOf(aToI[iterations]) + String.valueOf(i + 1);
        final int id = getResources().getIdentifier(idString, "id", getPackageName());
        gridSpaces[i] = new Tile(getApplicationContext());
        gridSpaces[i].setText("");
        gridSpaces[i].setHeight(40);
        gridSpaces[i].setWidth(40);
        gridSpaces[i].setLayoutParams(buttonParams);
        gridSpaces[i].setId(id);
        OnClickListener showID = new OnClickListener(){
            public void onClick(View view){                 
                TextView text = (TextView) findViewById(R.id.tileIDText);
                String tileID = getApplicationContext().getResources().getResourceEntryName(id);
                text.setText(tileID);
                Tile clickedTile = (Tile) findViewById(id);
                clickedTile.tileClick(0, tileID);
            }
        };
        gridSpaces[i].setOnClickListener(showID);
    }
    LinearLayout buttonRow = new LinearLayout(getApplicationContext());
    buttonRow.setOrientation(LinearLayout.HORIZONTAL);
    buttonRow.setLayoutParams(buttonParams);
    LinearLayout boardSpace = (LinearLayout) this.findViewById(R.id.boardLayout);
    for (int i = 0; i < gridSpaces.length; i++) {
        buttonRow.addView(gridSpaces[i]);
    }
    boardSpace.addView(buttonRow);
}

Here is the tileClick method mentioned above:

    public void tileClick(int action, String tileID) {
    switch(action) {
        case 1 :
            action 1
        case 2 :
            action 2
        default :
            Context context = getContext();
            Toast toast = new Toast(context);
            Toast.makeText(context, tileID, Toast.LENGTH_SHORT);
            toast.show();
    }
}

LogCat displays the following:

02-22 20:45:14.623: E/AndroidRuntime(7868): FATAL EXCEPTION: main
02-22 20:45:14.623: E/AndroidRuntime(7868): java.lang.RuntimeException: setView must have been called
02-22 20:45:14.623: E/AndroidRuntime(7868):     at android.widget.Toast.show(Toast.java:103)
02-22 20:45:14.623: E/AndroidRuntime(7868):     at com.jneal.ecquire.Tile.tileClick(Tile.java:51)
02-22 20:45:14.623: E/AndroidRuntime(7868):     at com.jneal.ecquire.GameBoardActivity$1.onClick(GameBoardActivity.java:55)
02-22 20:45:14.623: E/AndroidRuntime(7868):     at android.view.View.performClick(View.java:3627)
02-22 20:45:14.623: E/AndroidRuntime(7868):     at android.view.View$PerformClick.run(View.java:14329)
02-22 20:45:14.623: E/AndroidRuntime(7868):     at android.os.Handler.handleCallback(Handler.java:605)
02-22 20:45:14.623: E/AndroidRuntime(7868):     at android.os.Handler.dispatchMessage(Handler.java:92)
02-22 20:45:14.623: E/AndroidRuntime(7868):     at android.os.Looper.loop(Looper.java:137)
02-22 20:45:14.623: E/AndroidRuntime(7868):     at android.app.ActivityThread.main(ActivityThread.java:4511)
02-22 20:45:14.623: E/AndroidRuntime(7868):     at java.lang.reflect.Method.invokeNative(Native Method)
02-22 20:45:14.623: E/AndroidRuntime(7868):     at java.lang.reflect.Method.invoke(Method.java:511)
02-22 20:45:14.623: E/AndroidRuntime(7868):     at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:976)
02-22 20:45:14.623: E/AndroidRuntime(7868):     at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:743)
02-22 20:45:14.623: E/AndroidRuntime(7868):     at dalvik.system.NativeStart.main(Native Method)

What’s going on? I got almost identical code for displaying toasts in my MainActivity.java and it executed without problems.
Is it because I extended the Button and it doesn’t know what the View already is?
Also, Eclipse didn’t allow me to add setView() for some reason. I’m sure I’m having encapsulation issues here, but I’m confused about what they are.
Thank you in advance for your help.
Gerard

Solution

Change the following

line of code to the following line of code:

        Toast toast = new Toast(context);
        Toast.makeText(context, tileID, Toast.LENGTH_SHORT);
        toast.show();

Change to:

    Toast toast = Toast.makeText(context, tileID, Toast.LENGTH_SHORT);
    toast.show();       

As you can see from the source code, the exception is thrown only if mNextView is null.
The function “makeText” should set it, it does set it, but your original code doesn’t capture a reference to the toast it built. Instead, your original code creates two toasts and tries to “show” the one whose View has not been set.

public void show() {
    if (mNextView == null) {
        throw new RuntimeException("setView must have been called");
    }

....

public static Toast makeText(Context context, CharSequence text, int duration) {
    Toast result = new Toast(context);

LayoutInflater inflate = (LayoutInflater)
            context.getSystemService(Context.LAYOUT_INFLATER_SERVICE);
    View v = inflate.inflate(com.android.internal.R.layout.transient_notification, null);
    TextView tv = (TextView)v.findViewById(com.android.internal.R.id.message);
    tv.setText(text);

result.mNextView = v;
    result.mDuration = duration;

return result;
}

Related Problems and Solutions